Fix error with large size initialisation in nocomp mode #1072
Conversation
Add a call to h_allom so that trees can be demoted in canopy_structure
Small quality of life update to cohort age in create_cohort
There was a problem hiding this comment.
Looks good, makes sense.
Stretch goal: In the call to create_cohort, we've already updated that named argument to convey a zero aged cohort. How about that integer value of 1 that we pass. I think it is canopy layer. Perhaps we should use a named constant there too. Actually, I'm surprised we pass anything in, we shouldn't be defining the layer upon create cohort, that is an emergent phenomonena. It almost seems better to pass nothing and set it to uninitialized. I'll make an issue instead.
|
Here is the new issue: #1082 |
|
running tests: /glade/scratch/rgknox/tests_0928-180603ch tests pass, merging |
Fixes #1071. Initialisation by dbh was failing in no comp mode because height was not being initialised. This PR adds a call to h_allom so that trees can be demoted in canopy_structure if site spread has been updated in the first time step.
Collaborators:
Expectation of Answer Changes:
nocomop initialisation by dbh should now run, rather than result in an error.
Checklist:
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output:
Compiles and runs on Perlmutter with https://github.com/glemieux/E3SM/tree/lnd/fates-refactor E3SM branch and latest FATES commit.